[coreboot] [patch]show the version of code we are running

[Bao, Zheng]

OK. It is moved to version string.

Zheng

Signed-off-by: Zheng Bao <zheng.bao at amd.com>

-----Original Message-----
From: Myles Watson [mailto:mylesgw at gmail.com] 
Sent: Wednesday, April 08, 2009 2:05 AM
To: Bao, Zheng
Cc: coreboot at coreboot.org
Subject: Re: [coreboot] show the version of code we are running

On Tue, Apr 7, 2009 at 12:06 AM, Bao, Zheng <Zheng.Bao at amd.com> wrote:
> Sometimes when we debug the code, we need to know which version we are
> working on.

I like the idea.  I'd like it better if it were part of the version
string instead of the extraversion.

Myles

> Zheng
>
> Signed-off-by: Zheng Bao <zheng.bao at amd.com>
>
>
>
> Index: src/boot/hardwaremain.c
> ===================================================================
> --- src/boot/hardwaremain.c     (revision 4080)
> +++ src/boot/hardwaremain.c     (working copy)
> @@ -58,7 +58,7 @@
>
>        post_code(0x39);
>
> -       printk_notice("coreboot-%s%s %s %s...\n",
> +       printk_notice("coreboot-%s-r%s %s %s...\n",
>                      coreboot_version, coreboot_extra_version,
> coreboot_build,
>                      (boot_complete)?"rebooting":"booting");
>
> Index: src/config/Options.lb
> ===================================================================
> --- src/config/Options.lb       (revision 4080)
> +++ src/config/Options.lb       (working copy)
> @@ -103,7 +103,7 @@
>        comment "coreboot version"
>  end
>  define COREBOOT_EXTRA_VERSION
> -        default ""
> +        default "$(shell if [ -x /usr/bin/svnversion ]; then
> /usr/bin/svnversion $(TOP); fi)"
>         export used
>        format "\"%s\""
>         comment "coreboot extra version"
> Index: src/arch/i386/lib/console.c
> ===================================================================
> --- src/arch/i386/lib/console.c (revision 4080)
> +++ src/arch/i386/lib/console.c (working copy)
> @@ -30,6 +30,7 @@
>        static const char console_test[] =
>                "\r\n\r\ncoreboot-"
>                COREBOOT_VERSION
> +               "-r"
>                COREBOOT_EXTRA_VERSION
>                " "
>                COREBOOT_BUILD
>
>
> --
> coreboot mailing list: coreboot at coreboot.org
> http://www.coreboot.org/mailman/listinfo/coreboot
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: show_svnversion.patch
Type: application/octet-stream
Size: 421 bytes
Desc: show_svnversion.patch
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090408/44b27892/attachment.obj>