[coreboot] [PATCH] romcc --include=settings.h support

Peter Stuge peter at stuge.se
Fri Apr 3 15:54:21 CEST 2009

Stefan Reinauer wrote:
> >>  	compile_file(&state, filename, 1);
> >> +	if (includefile)
> >> +		compile_file(&state, includefile, 1);
> >
> > Shouldn't the include be compiled before the actual file?
> Yes, but romcc seems to parse it the other way round. My tests
> showed the above produces correct results, while turning the
> statements around does not (the first version of my patch looked
> that way)

Hah! Ok. :) I guess it builds some kind of data structure which is
finally processed in reverse order.

Thanks for explaining it - please put a note in the commit message.

Acked-by: Peter Stuge <peter at stuge.se>

More information about the coreboot mailing list