[coreboot] coreinfo: modwin initialization

Jordan Crouse jordan.crouse at amd.com
Wed Sep 24 16:23:39 CEST 2008


On 23/09/08 23:08 +0200, Ulf Jordan wrote:
> The attached patch fixes an overflow in the erasure of modwin, and removes 
> an unnecessary refresh.
> 
> Compile and runtime tested with coreinfo+libpayload+coreboot-v3 under 
> QEMU.
> 
> /ulf

> Fix overflow in modwin erase. Do not refresh modwin yet, since it is
> immediately overwritten by stdscr.
> 
> Signed-off-by: Ulf Jordan <jordan at chalmers.se>

Acked-by: Jordan Crouse <jordan.crouse at amd.com>

r3599.  Thank you.

> Index: coreinfo/coreinfo.c
> ===================================================================
> --- coreinfo/coreinfo.c.orig	2008-09-22 22:35:48.000000000 +0200
> +++ coreinfo/coreinfo.c	2008-09-22 22:48:57.000000000 +0200
> @@ -276,13 +276,7 @@
>  	wattrset(modwin, COLOR_PAIR(2));
>  	wattrset(menuwin, COLOR_PAIR(1) | A_BOLD);
>  
> -	for (i = 0; i < SCREEN_Y - 1; i++) {
> -		wmove(modwin, i - 1, 0);
> -		for (j = 0; j < SCREEN_X; j++)
> -			waddch(modwin, ' ');
> -	}
> -
> -	wrefresh(modwin);
> +	werase(modwin);
>  
>  	for (i = 0; i < ARRAY_SIZE(categories); i++) {
>  		for (j = 0; j < categories[i].count; j++)

> --
> coreboot mailing list: coreboot at coreboot.org
> http://www.coreboot.org/mailman/listinfo/coreboot


-- 
Jordan Crouse
Systems Software Development Engineer 
Advanced Micro Devices, Inc.





More information about the coreboot mailing list