[coreboot] patch: remove static variable from cs5536 smbus function

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Wed Sep 17 03:22:05 CEST 2008

On 17.09.2008 02:40, ron minnich wrote:
> You might like this one better.
> Just a tiny change, not code dup, but the opportunity is open for more
> complex cases.
> This global variable infrastructure is really nice.

Cool thing. You're using the infrastructure in novel ways and that makes
me happy.

The assignment is not MP safe, but I seriously doubt someone will use
the CS5536 in a MP environment. Besides that, the global variable
infrastructure is not MP safe right now, so I'll have to audit all users
anyway once I make the infrastructure MP safe.
Read the sentence above as "no objection, code is fine". ;-)

Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>



More information about the coreboot mailing list