[coreboot] patch: remove static variable from cs5536 smbus function

ron minnich rminnich at gmail.com
Tue Sep 16 02:49:33 CEST 2008

On Mon, Sep 15, 2008 at 5:01 PM, Peter Stuge <peter at stuge.se> wrote:

> But I don't like all the duplication. Could it be made more generic?

I don't like duplication but I don't want anything Clever. If you can
meet that one mental issue I have -- no Cleverness -- I'll go for it.

I would like to avoid weak symbols and preprocessor magic. Also, there
is duplication here, I admit, but ... we're going to like this spd
init hook a LOT once we get to mainboards with I2C muxes and such fun.

One thing I like about this for noobies is it is *really* obvious, no
matter what mainboard they look at, what functions they need to write
... I think it's very important to make it that obvious.


More information about the coreboot mailing list