[coreboot] [PATCH] v3: more uniqueness in the dtc generated struct names

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sat Sep 6 22:42:38 CEST 2008

On 05.09.2008 10:17, ron minnich wrote:
> On Wed, Sep 3, 2008 at 8:09 PM, Carl-Daniel Hailfinger wrote:
>> Hi Ron,
>> here's my patch proposal for struct device naming again. It has the
>> advantage of adding only 14 lines of code.
>> Regards,
>> Carl-Daniel
>> On 30.08.2008 00:57, Carl-Daniel Hailfinger wrote:
>>> I managed to break dtc while working on PCI bridges:
>>> dtc only uses dev_fn as identifier for a PCI device. That gets us a name
>>> collision if we have the same dev_fn combination on multiple buses.
>>> [...]
>>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
> Acked-by: Ronald G. Minnich <rminnich at gmail.com>
> not yet tested. But some test builds look good.

Thanks. Per the discussion in other threads, I committed this as r860.
Feel free to change the naming scheme anytime.



More information about the coreboot mailing list