[coreboot] libpayload keyboard driver fix.

Jordan Crouse jordan.crouse at amd.com
Tue Sep 2 16:58:58 CEST 2008

On 01/09/08 21:29 +0200, Patrick Georgi wrote:
> Uwe Hermann schrieb:
> > On Mon, Sep 01, 2008 at 05:53:54PM +0200, Stefan Reinauer wrote:
> >   
> >> fix keyboard driver bugs.
> >>     
> >
> > Jordan is probably better-suited to review this, but can you elaborate
> > a bit more in the commit message? What bug, what's wrong, what effects does
> > the bug have, how is it fixed, etc?
> >   
> The |0x80 codes are "break codes", that means, codes that are emitted
> when the key transitions from pressed to non-pressed, so the modifier
> was always in the wrong state, as soon as you pressed shift for the
> first time.
> I have no idea why that didn't occur to me when I looked at it earlier
> today :-/
> Acked-by: Patrick Georgi <patrick.georgi at coresystems.de>

Thats right - I hosed up that state machine and never noticed it because
we have never had any payloads that used special keys to any degree.

Also acked by me.


More information about the coreboot mailing list