[coreboot] [PATCH]es remaining 3 of 7 assorted fixes

Jens Rottmann JRottmann at LiPPERTEmbedded.de
Thu Oct 30 18:15:37 CET 2008


autoboot_delay.diff (changes filo.c):
Fixes compile error if AUTOBOOT_DELAY=0.

fs_arch.diff (changes ext2fs.c, fat.c):
#if ARCH == 'i386'
results in a compile warning: "multi-character character constant" and
the condition ARCH=='i386' is mis-evaluated as FALSE, eventually choking
the assembler on a PPC instruction. Changed it to
#ifdef __i386

it8712_gpio.diff (changes superio.c (IT8712F)):
Added the missing I/O resources for IT8712F GPIOs. Our boards need those
e.g. to switch the com ports from RS232 to RS485.

Signed-off-by: Jens Rottmann <JRottmann at LiPPERTEmbedded.de>
---

Above are my remaining 3 fixes/improvements. Anyone please comment (or,
preferably, commit :-)  Again, thanks to Marc, who kindly already took
care of the other 4. The patches are independent of each other.

Note about fs_arch.diff:
Complete build output was attached to my previous mail.

Note about it8712_gpio.diff:
The IT8712F manual makes it look like PNP_IO1 had a size/granularity of
1 byte, but that must be a mistake. The Simple-I/O resource has a size
of 5 bytes (1 for each GPIO set 1-5) and trying different addresses
reveals a granularity of 8.

Regards,
Jens Rottmann

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: fs_arch.diff
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20081030/4414d11a/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: it8712_gpio.diff
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20081030/4414d11a/attachment-0001.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: autoboot_delay.diff
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20081030/4414d11a/attachment-0002.ksh>


More information about the coreboot mailing list