[coreboot] filo circular console list

Arne Georg Gleditsch arne.gleditsch at numascale.com
Thu Oct 30 15:59:44 CET 2008


Jordan Crouse <jordan.crouse at amd.com> writes:
> My bad - they are using a custom entry point (see i386/switch.S in filo).
> So, they do need to call console_init() and lib_get_sysinfo(). Your
> patch is correct.

Yes, I verified that console_out was NULL when entering filo.c's init().

> Acked-by: Jordan Crouse <jordan.crouse at amd.com>

Oh, in case it matters:

Signed-off-by: Arne Georg Gleditsch <arne.gleditsch at numascale.com>

>> > Index: main/filo.c
>> > ===================================================================
>> > --- main/filo.c	(revision 83)
>> > +++ main/filo.c	(working copy)
>> > @@ -49,9 +49,6 @@
>> >  {
>> >      /* Set up the consoles. */
>> >      console_init();
>> > -#ifdef CONFIG_VIDEO_CONSOLE
>> > -    video_console_init();
>> > -#endif
>> >  
>> >      /* Gather system information, and implicitly sets up timers */
>> >      lib_get_sysinfo();

-- 
								Arne.




More information about the coreboot mailing list