[coreboot] r964 - coreboot-v3/util/x86emu

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Thu Oct 30 01:20:52 CET 2008


On 30.10.2008 01:14, Stefan Reinauer wrote:
> Carl-Daniel Hailfinger wrote:
>   
>> On 29.10.2008 23:36, ron minnich wrote:
>>   
>>     
>>> Just unshare. I am happy with patches that eliminate shared code entirely.
>>>   
>>>     
>>>       
>> Unsharing just postpones the problem for another 6 months or so. After
>> that, the new code will fail as well. Besides that, wasting the whole
>> boot block is not exactly my idea of efficiency.
>>   
>>     
> No, unsharing nicely solves the problem.
>   

We already have graphics cards with 2 GB RAM, so anything above 2 GB is
unreachable during sizing. For a graphics card with 4 GB RAM, every
single freaking 32bit location will be inaccessible. That means it it
totally irrelevant whether you unshare or not, the machine will simply fail.


>> Anyone thinking of this should be aware that unsharing will be LOTS of
>> fun, especially considering global variables, avoiding garbage on serial
>> and so on. 
>>     
> We don't share in v2, and we have no garbage there.
>   

Well, do we use printk in v2 before setting up serial? AFAICS we don't,
so the problem doesn't apply to v2. Of course that problem can be fixed
in v3 by removing lots of early printk calls, but I prefer to avoid that.


>> We will need to compile code with different #ifdef sections
>> based on where it lives and previously shared parts of the code will
>> look more and more like old ROMCC code.
>>   
>>     
> There be dragons.
>   

Indeed.


Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the coreboot mailing list