[coreboot] [PATCH 5/6] Changes required to the device allocator

Stefan Reinauer stepan at coresystems.de
Wed Oct 29 17:24:07 CET 2008


Myles Watson wrote:
>   
>> -----Original Message-----
>> From: Stefan Reinauer [mailto:stepan at coresystems.de]
>> Sent: Tuesday, October 28, 2008 9:16 PM
>> To: Myles Watson
>> Cc: 'Coreboot'
>> Subject: Re: [coreboot] [PATCH 5/6] Changes required to the device
>> allocator
>>
>> Myles Watson wrote:
>>     
>>>> Changes required to the device allocator:
>>>> - leave a hole for mmapped PCIe config space if
>>>>
>>>>         
>>> CONFIG_PCIE_CONFIGSPACE_HOLE
>>>
>>>       
>>>>   is set.
>>>> - Mask moving bits to 32bit when resources are not supposed above 4G.
>>>>
>>>>         
>>> Linux
>>>
>>>       
>>>>   does not like this, even though the resource is disabled.
>>>>
>>>> Signed-off-by: Stefan Reinauer <stepan at coresystems.de>
>>>>
>>>>         
>>> Looks good.  would it be better to set the resource to 0 instead of to
>>> moving bits?  Then there would not be a need for the special case.  It
>>>       
>> also
>>     
>>> makes it easier to read the config space.
>>>
>>> Acked-by: Myles Watson <mylesgw at gmail.com>
>>>       
>> Thanks! r3699.
>>
>> According to Ron and Eric, setting the resource to 0 will not work on
>> some devices. I know factory bios has done it on at least the bridges
>> I've seen so I am not sure what the right behavior would be. Setting
>> them to 0 would seem the right thing.
>>     
>
> Should we consider fix-ups for broken boards, then?  How common is it?
>   
Yes, that's what I've been thinking too.


-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866





More information about the coreboot mailing list