[coreboot] v3 __func0 cleanup

Myles Watson mylesgw at gmail.com
Tue Oct 28 21:27:54 CET 2008

On Tue, Oct 28, 2008 at 2:15 PM, Marc Jones <Marc.Jones at amd.com> wrote:

> Myles Watson wrote:
>> This patch documents the unreadable function in northbridge/amd/k8/pci.c
>> and
>> cleans up the NULL pointer protection.
>> Signed-off-by: Myles Watson <mylesgw at gmail.com <mailto:mylesgw at gmail.com
>> >>
> Untested but this looks correct to me. See if Ron has some comment.
> Acked-by: Marc Jones <marc.jones at amd.com>


>> It also begs the question why cpu_bus_scan and cpu_bus_init aren't needed
>> in v3.  They aren't called.  Is that an oversight, or should they be
>> removed.
> I think it is because the HT init (cpu setup) is all done pre-memory and
> done by the time dts is used. This could change if the dts is present in
> stage1.

Do you know what the corresponding functions are in v3?

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20081028/9a710123/attachment.html>

More information about the coreboot mailing list