[coreboot] filo serial console problems

Marc Jones Marc.Jones at amd.com
Thu Oct 23 01:33:11 CEST 2008

Patrick Georgi wrote:
> Jordan Crouse schrieb:
>> On 20/10/08 17:16 -0600, Marc Jones wrote:
>>> It looks like filo has some problems with serial console.
>>> 1. left arrow: reboots the system
>> Lots of left arrows - presumably any escape related key would be
>> affected.  This has been reported before, but it doesn't seem to
>> break in qemu, only on real hardware.
> The attached patch limits the amount of characters read for escape
> handling to the size of the buffer.
> It also changes the recursion to a while loop. A compiler "should"
> resolve the tail recursion, but I'd rather be sure.
> Signed-off-by: Patrick Georgi <patrick.georgi at coresystems.de>

This is a lot better. It doesn't just reboot if I use the left arrow.
If hold the back arrow down for a few seconds it will reboot when I on 
the release.

Based on the improvement
Acked-by: Marc Jones <marc.jones at amd.com>


Marc Jones
Senior Firmware Engineer
(970) 226-9684 Office
mailto:Marc.Jones at amd.com

More information about the coreboot mailing list