[coreboot] patch: unshare pci operations

Myles Watson mylesgw at gmail.com
Tue Oct 21 15:32:53 CEST 2008



> -----Original Message-----
> From: coreboot-bounces at coreboot.org [mailto:coreboot-bounces at coreboot.org]
> On Behalf Of Carl-Daniel Hailfinger
> Sent: Tuesday, October 21, 2008 12:28 AM
> To: ron minnich
> Cc: Marc Jones; Coreboot
> Subject: Re: [coreboot] patch: unshare pci operations
> 
> On 21.10.2008 01:50, ron minnich wrote:
> > On Mon, Oct 20, 2008 at 4:42 PM, Marc Jones <Marc.Jones at amd.com> wrote:
> >
> >> ron minnich wrote:
> >>
> >>> Unshare these, as we can not use them when  buggy PCI expansion ROMS
> >>> are active and are hiding ROM.
> >>>
> >>>
> >> Acked-by: Marc Jones <marc.jones at amd.com>
> >>
> >>
> >
> > Revision 940.
> >
> > Now we have to unshare the console functions; a bit trickier as they
> > may also call string functions. I figure we will leave LAR shared.
> >
> 
> What about mapping the bootblock to the ROM window below 1M as was
> discussed some time ago? I know it does not exactly look like fun, but
> AFAIK all recent and ancient chipsets mirror the top 64k there.
> 
> Regards,
> Carl-Daniel
> 
> P.S. I'd just say that calling console functions from during the ROM
> mapping is illegal. It's our code, we get to specify what is run.

That's the way I'm running now.  The problem would be if someone in the
future wanted to debug why their option ROM was failing, and added a few
printks. 

Thanks,
Myles






More information about the coreboot mailing list