[coreboot] [PATCH] v2: BCOM WinNETP680 improvements

Corey Osgood corey.osgood at gmail.com
Fri Oct 17 19:41:29 CEST 2008

2008/10/17 Uwe Hermann <uwe at hermann-uwe.de>

> See patch.

Drop unneeded enable_mainboard_devices() function, the lines
>       register "fn_ctrl_lo" = "0x80"
>       register "fn_ctrl_hi" = "0x1d"
> in the Config.lb file should do exactly the same (but please test that)!
> Also, drop some unused variables and (IMHO) unneeded debug messages.

NACK. If the devices aren't enabled/disabled (and in the process
hidden/revealed) before PCI bringup, coreboot will get very confused when
they disappear and appear out of nowhere.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20081017/c5ec5e5d/attachment.html>

More information about the coreboot mailing list