[coreboot] v3 comments - was Serengeti vga hang

[Marc Jones]

ron minnich wrote:
> On Wed, Oct 15, 2008 at 10:36 AM, Marc Jones <Marc.Jones at amd.com> wrote:
...
>>
>>
>> Where is phase4_enable_disable? Shouldn't it happen before Phase 4: Reading
>> resources ?
> 
> It does, for each device, if it is set up for that device.
> 
> phase4_enable_disable was in v2 in a different name. The problem is
> that sometimes you have to enable a device to read the resources.
> phase4_enable_disable looks at dev->enabled and enables "whatever has
> to be enabled" -- it's device dependent -- so that resources can be
> read. It's called enable_disable because it can do both, depending on
> device_enabled, and I was not clever enough to think of a better name
> :-)
> 
> For most devices, it's empty.
> 

Sorry but I don't see any phase4_enable_disable in the output. It is not 
being called in device.c dev_phase4(). I think that is a problem.


Marc


-- 
Marc Jones
Senior Firmware Engineer
(970) 226-9684 Office
mailto:Marc.Jones at amd.com
http://www.amd.com/embeddedprocessors