[coreboot] [v2][patch] update k8 fid/vid setup

Uwe Hermann uwe at hermann-uwe.de
Fri Oct 10 20:36:40 CEST 2008

On Wed, Oct 01, 2008 at 02:57:03PM -0600, Marc Jones wrote:
> Resubmitting this patch. I think I worked out all the corner cases and  
> made it a little easier to understand.

This will probably break the build on some boards, e.g.:

Processing mainboard/asus/a8v-e_se (i386: ok)
  Creating config file... ok
  Creating builddir...ok
  Compiling image on 1 cpu .. FAILED after 4s! Log excerpt:
cache_as_ram_auto.c:(.rom.text+0x3a34): undefined reference to `printk_debug'
collect2: ld returned 1 exit status
make[1]: *** [coreboot] Error 1

I think the reason is this:

> +	printk_debug("Current fid_cur: %x\n", fid_cur);
> +	printk_debug("Requested fid_new: %x\n", fid_new);

All other printk_*'s in this file are "protected" similar to this:

                printk_debug("%s%x\r\n", str, val);
                print_debug(str); print_debug_hex32(val); print_debug("\r\n");

I'll check if that'd fix the issue.

http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

More information about the coreboot mailing list