[coreboot] patch: print out msg level on printk

[Stefan Reinauer]

Carl-Daniel Hailfinger wrote:
> On 05.10.2008 07:29, ron minnich wrote:
>   
>> This patch provides output like this:
>> <8>dynamic PCI: 00:0b.1(PCI: 00:0b.1): enabled 1 have_resources 1 initialized 1
>> <7>Stage2 code done.
>> <6>LAR: Attempting to open 'normal/payload/segment0'.
>> <8>LAR: Start 0xfff80000 len 0x80000
>> <8>LAR: seen member normal/option_table at 0xfff80000, size 1776
>> <8>LAR: seen member normal/initram/segment0 at 0xfff80740, size 31644
>>
>> We can thus get SPEW data but then easily filter it by log level.
>>   
>>     
>
> AFAICS this will look strange for multiline and half-line printk statements.
> Hm. We could check whether the last printed character was \n and add the
> prefix only then. That fixes the half-line case.
> The multiline case is a bit more difficult.
>   

I think printing the log level makes sense only if there's a klogd
running on the other side. But I don't particularly care either. It
should be an option, and yes, it should be fixed the way Carl-Daniel
suggests, if it goes in.

Stefan

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de  • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20081006/ab6cb2d8/attachment.sig>