[coreboot] [PATCH] flashrom: Fix probe_spi_res failover

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Fri Nov 28 00:01:08 CET 2008

On 27.11.2008 19:37, FENG Yu Ning wrote:
> On Fri, Nov 28, 2008 at 1:32 AM, Carl-Daniel Hailfinger
> <c-d.hailfinger.devel.2006 at gmx.net> wrote:
>> The existing check in probe_spi_res() was right for SPI controllers
>> which support all commands, but may not exist.
>> For controllers which support only a subset of commands, it will fail in
>> unexpected ways.
> sometimes the controller supports that command, but the command is
> 1. not in the opmenu, and we cannot change it (spi conf locked down)
> 2. the slave spi flash chip does not support rdid.
> for example, my ich7 + sst25lf040a (both 1. and 2.)
> There is also BBAR issue in the probing process and more. spi_res only
> reads from address 0x0, which could be below BBA. And there is
> read-only opmenu index difference with our hardcoded opcodes table.
> They are other problems to attack against seperately, though.
> Obviousely ack from me is not decisive, but still
> Acked-by: FENG yu ning <fengyuning1984 at gmail.com>

Thanks, r3774.



More information about the coreboot mailing list