[coreboot] [PATCH] add debug information to v2 builds

[Carl-Daniel Hailfinger]

On 27.11.2008 20:24, Uwe Hermann wrote:
> On Thu, Nov 27, 2008 at 02:40:43PM +0100, Stefan Reinauer wrote:
>   
>> This patch from Ralf Grosse Boerger makes debugging more comfortable. 
>> With this patch it's possible to 
>>
>> - determine the according source code line for each asm statement
>>   (objdump -dS)
>> - determine the source code file for each asm statement 
>>   (objdump -ddl)
>>
>> This isn't exactly trivial because cache_as_ram_auto.c gets compiled to
>> assembly and converted by a perl script afterwards.
>>
>> This patch solves the problem 
>> - by extending cache_as_ram_auto.inc with debug information and line numbers
>> - by correcting the perl calls (".text" --> "\.text")
>> - by creating a disassembly with source code and line numbers. (ctr0.disasm and
>>   coreboot.disasm)
>>
>> There's one minor downside to the patch: A complete abuild run takes up around
>> 1.6G instead of about 700MB now. But I'm sure this is quite reasonable for the
>> benefits.
>>     
>
> Can we make this optional, please? 700MB is already quite a lot, let alone 1.6GB.
>
> The changes are fine with me, but there should be some option somewhere
> to not generate the extra 900MB of debug output if you don't want it.
>   

That's also one of the reasons why I didn't ack the complete patch. I do
coreboot development on my work machine which happens to be a laptop
with not enough hard disk space. I would have to delete some stuff to
run the new abuild.

AFAICS abuild images are not fully bootable anyway because they have no
payload. I may be wrong, though. However, if I'm right, the debug
symbols in abuild don't help anyone. Debug symbols in "real" builds
would make sense.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/