[coreboot] r1040 - coreboot-v3/superio/winbond/w83627thg

[Uwe Hermann]

On Mon, Nov 17, 2008 at 09:48:31PM +0100, Peter Stuge wrote:
> > +	/* Floppy */
> > +	floppydev = "0";
> > +	floppyenable = "0";
> > +	floppyio = "0x3f0";
> > +	floppyirq = "6";
> > +	floppydrq = "2";
> 
> I would like to veto this style -

I agree that this is not ideal, I don't like it either. Especially
encoding LDN names into variable names is crap, we have to find a better
way to do that (arrays or something, so that the functions in superio.c
can be dropped in favor of one common, nice function that iterates over
an array and that we _don't_ have to rewrite for every superio.c).

This stuff below should be totally unnecessary later:

        [...]
        /* Keyboard */
        pnp_dev_info[IT8716F_KBCK].enable = conf->kbenable;
        pnp_dev_info[IT8716F_KBCK].io0.val = conf->kbio;
        pnp_dev_info[IT8716F_KBCK].io1.val = conf->kbio2;
        pnp_dev_info[IT8716F_KBCK].irq0.val = conf->kbirq;

        /* PS/2 mouse */
        pnp_dev_info[IT8716F_KBCM].enable = conf->mouseenable;
        pnp_dev_info[IT8716F_KBCM].irq0.val = conf->mouseirq;

        /* GPIO */
        pnp_dev_info[IT8716F_GPIO].enable = conf->gpioenable;
        [...]

I'm not saying I know the perfect way to achieve this, but we should
try to find a good solution here.


> it's not the dts way, it's the v2 way.

Can you explain what you refer to as "dts way"? How should it look like?


> Sorry if there is already consensus on this issue, but I would really
> like something more dtsy than that for the pnps.

Yep.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org