[coreboot] [PATCH] flashrom: Check for failed SPI command execution

Peter Stuge peter at stuge.se
Mon Nov 17 21:45:34 CET 2008

Stefan Reinauer wrote:
> Hm.. So do we need to keep an array of supported read, write,
> erase, id opcodes for each spi chip to handle this?

Yes, that is the best we can do. We should also keep track of which
commands can be executed on which SPI masters; some have limited
command sets, others only have limits on number of bytes transferred
in command and response, which in turn limits which commands can be

> That one function does one job, but I'm a little concerned that we
> end up writing functions for all possible variations of possible
> commands and have a hard time tracking it afterwards.

Until flashrom can understand the entire path to the chip I think
it's fine.


More information about the coreboot mailing list