[coreboot] r1009 - in coreboot-v3: mainboard/kontron/986lcd-m northbridge/intel/i945 southbridge/intel/i82801gx

[ron minnich]

Try this.

This started out because in the kontron board ide is commented out.


On Wed, Nov 12, 2008 at 6:20 PM, Stefan Reinauer <stepan at coresystems.de> wrote:
> svn at coreboot.org wrote:
>> Fewer errors. The weird part: I had to move all the i82801gx south files to be compiled to the mainboard.
>>
>> Why? Because the board doesn't use ide support. So you can't compile that in, it's not in the dts.
>>
> Oh, the dts is not capable of marking a device unused? This looks like a
> major shortcoming. I thought we had a discussion about a disabled flag
> in the past that would allow disabling a device.
>
> But: The board uses IDE support.

But: it's commented out.
                        #device pci 1f.1 off end # IDE


> So, the generic ICH7 device structure is described in the mainboard dts?
> We need to mention in the mainboard dts that there's 1f,0 and 1f,2 and
> which config it uses? That's a rather generic device description

It's right ouf of Config.lb. It's how we've written all dts to date.

>
>> Modified: coreboot-v3/southbridge/intel/i82801gx/sata.dts
>> ===================================================================
>> --- coreboot-v3/southbridge/intel/i82801gx/sata.dts   2008-11-12 22:43:50 UTC (rev 1008)
>> +++ coreboot-v3/southbridge/intel/i82801gx/sata.dts   2008-11-12 23:09:42 UTC (rev 1009)
>> @@ -20,4 +20,9 @@
>>
>>  {
>>       device_operations = "i82801gx_sata_normal_driver";
>> +     ide_legacy_combined = "0";
>> +     ide_enable_primary = "0";
>> +     ide_enable_secondary = "0";
>> +     sata_ahci = "0";
>>  };
>> +
>>
> --- and --- the mainboard specific variables are in the generic code?

not sure what you mean. Are these mainboard specific or sata specific?
It is hard to tell from the v2 stuff. I am only guessing.

ron
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kontron.diff
Type: application/octet-stream
Size: 9434 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20081112/d06cce77/attachment.obj>