[coreboot] r1009 - in coreboot-v3: mainboard/kontron/986lcd-m northbridge/intel/i945 southbridge/intel/i82801gx

Stefan Reinauer stepan at coresystems.de
Thu Nov 13 03:20:30 CET 2008


svn at coreboot.org wrote:
> Fewer errors. The weird part: I had to move all the i82801gx south files to be compiled to the mainboard. 
>
> Why? Because the board doesn't use ide support. So you can't compile that in, it's not in the dts. 
>   
Oh, the dts is not capable of marking a device unused? This looks like a
major shortcoming. I thought we had a discussion about a disabled flag
in the past that would allow disabling a device.

But: The board uses IDE support.



Only a quick glance at the DTS stuff, but it's confusing me:
> Modified: coreboot-v3/mainboard/kontron/986lcd-m/dts
> ===================================================================
> --- coreboot-v3/mainboard/kontron/986lcd-m/dts	2008-11-12 22:43:50 UTC (rev 1008)
> +++ coreboot-v3/mainboard/kontron/986lcd-m/dts	2008-11-12 23:09:42 UTC (rev 1009)
> @@ -181,6 +181,13 @@
>   				pci at 1f,0{/* which ich? */
>  					/config/("southbridge/intel/i82801gx/ich7m_dh_lpc.dts");
>  				};
> +      				pci at 1f,2{
> +					/config/("southbridge/intel/i82801gx/sata.dts");
> +				};
> +        				pci at 1f,3{
> +					/config/("southbridge/intel/i82801gx/smbus.dts");
> +				};
> +
>  		};
>  		ioport at 2e {
>  			/config/("superio/winbond/w83627thg/dts");
>
>   
So, the generic ICH7 device structure is described in the mainboard dts?
We need to mention in the mainboard dts that there's 1f,0 and 1f,2 and
which config it uses? That's a rather generic device description

> Modified: coreboot-v3/southbridge/intel/i82801gx/sata.dts
> ===================================================================
> --- coreboot-v3/southbridge/intel/i82801gx/sata.dts	2008-11-12 22:43:50 UTC (rev 1008)
> +++ coreboot-v3/southbridge/intel/i82801gx/sata.dts	2008-11-12 23:09:42 UTC (rev 1009)
> @@ -20,4 +20,9 @@
>  
>  {
>  	device_operations = "i82801gx_sata_normal_driver";
> +	ide_legacy_combined = "0";
> +	ide_enable_primary = "0";
> +	ide_enable_secondary = "0";
> +	sata_ahci = "0";
>  };
> +
>   
--- and --- the mainboard specific variables are in the generic code?

Now, this is definitely very unexpected. Is this a shortcoming in our
DTS/DTC concept? Something's really fishy here.


-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866






More information about the coreboot mailing list