[coreboot] [PATCH 1/5] Return the count of failures from ram_check.

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Thu Nov 13 01:46:01 CET 2008

On 13.11.2008 01:18, Mart Raudsepp wrote:
> Return the count of failures from ram_check.
> Will be necessary for DBE61 automatic memory size selection.
> Signed-off-by: Mart Raudsepp <mart.raudsepp at artecdesign.ee>

We really want __attribute__((warn_unused_result)) for ram_check.

Besides that, lib/ramtest.c could use some cleanups. ram_read_phys() and
ram_write_phys() are nothing but really complicated versions of readl()
and writel(). It would be cool if you could tackle that in another patch.

Anyway, this patch improves the current situation, so it is
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>



More information about the coreboot mailing list