[coreboot] [PATCH 5/5] Be less noisy in ram_check in non-debug loglevels

Mart Raudsepp mart.raudsepp at artecdesign.ee
Thu Nov 13 01:20:15 CET 2008


Be less noisy in ram_check in non-debug loglevels

As DBE61 support now runs ram_check for non-debug purposes and has expected failures,
downgrade the per-address looped fail notification printk from BIOS_ERR to BIOS_DEBUG.
To compensate promote the one-time result print from DEBUG to ERR if it was a failure.

Signed-off-by: Mart Raudsepp <mart.raudsepp at artecdesign.ee>
---
 lib/ramtest.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/ramtest.c b/lib/ramtest.c
index 02a4bdb..24af6b4 100644
--- a/lib/ramtest.c
+++ b/lib/ramtest.c
@@ -97,7 +97,7 @@ static int ram_verify(unsigned long start, unsigned long stop)
 		value = ram_read_phys(addr);
 		if (value != addr) {
 			/* Display address with error. */
-			printk(BIOS_ERR, "Fail @%lx Read value=%lx\n",
+			printk(BIOS_DEBUG, "Fail @%lx Read value=%lx\n",
 			       addr, value);
 			/* Abort after 256 verify errors. */
 			if (++i > 256) {
@@ -111,7 +111,7 @@ static int ram_verify(unsigned long start, unsigned long stop)
 	printk(BIOS_DEBUG, "%lx\r", addr);
 
 	/* Print whether or not the verify failed. */
-	printk(BIOS_DEBUG, "\nDRAM range %sverified.", i ? "_NOT_ " : "");
+	printk(i ? BIOS_ERR : BIOS_DEBUG, "\nDRAM range %sverified.\n", i ? "_NOT_ " : "");
 	return i;
 }
 
-- 
1.6.0.2





More information about the coreboot mailing list