[coreboot] [PATCH 3/5] artecgroup/dbe61: Gather RAM initialization function calls to one helper function.

Mart Raudsepp mart.raudsepp at artecdesign.ee
Thu Nov 13 01:19:23 CET 2008


artecgroup/dbe61: Gather RAM initialization function calls to one helper function.

Then we can later use it for re-initializing for different SPD without code duplication.

Signed-off-by: Mart Raudsepp <mart.raudsepp at artecdesign.ee>
---
 mainboard/artecgroup/dbe61/initram.c |   27 ++++++++++++++++-----------
 1 files changed, 16 insertions(+), 11 deletions(-)

diff --git a/mainboard/artecgroup/dbe61/initram.c b/mainboard/artecgroup/dbe61/initram.c
index 4a89247..d454e46 100644
--- a/mainboard/artecgroup/dbe61/initram.c
+++ b/mainboard/artecgroup/dbe61/initram.c
@@ -135,6 +135,21 @@ static void mb_gpio_init(void)
 	/* Early mainboard specific GPIO setup */
 }
 
+static void initialize_ram(u8 dimm0, u8 dimm1)
+{
+	cpu_reg_init(0, dimm0, dimm1, DRAM_UNTERMINATED);
+	printk(BIOS_DEBUG, "done cpu reg init\n");
+
+	sdram_set_registers();
+	printk(BIOS_DEBUG, "done sdram set registers\n");
+
+	sdram_set_spd_registers(dimm0, dimm1);
+	printk(BIOS_DEBUG, "done sdram set spd registers\n");
+
+	sdram_enable(dimm0, dimm1);
+	printk(BIOS_DEBUG, "done sdram enable\n");
+}
+
 /** 
   * main for initram for the PC Engines Alix 1C.  It might seem that you
   * could somehow do these functions in, e.g., the cpu code, but the
@@ -155,17 +170,7 @@ int main(void)
 	pll_reset(MANUALCONF, PLLMSRHI, PLLMSRLO);
 	printk(BIOS_DEBUG, "done pll reset\n");
 
-	cpu_reg_init(0, DIMM_DBE61C, DIMM_EMPTY, DRAM_UNTERMINATED);
-	printk(BIOS_DEBUG, "done cpu reg init\n");
-
-	sdram_set_registers();
-	printk(BIOS_DEBUG, "done sdram set registers\n");
-
-	sdram_set_spd_registers(DIMM_DBE61C, DIMM_EMPTY);
-	printk(BIOS_DEBUG, "done sdram set spd registers\n");
-
-	sdram_enable(DIMM_DBE61C, DIMM_EMPTY);
-	printk(BIOS_DEBUG, "done sdram enable\n");
+	initialize_ram(DIMM_DBE61C, DIMM_EMPTY);
 
 	/* Check low memory */
 	/*ram_check(0x00000000, 640*1024); */
-- 
1.6.0.2





More information about the coreboot mailing list