[coreboot] [PATCH] v3: s/BIOS_DEBUG/DEBUG/ etc. for printk()
uwe at hermann-uwe.de
Thu Nov 6 23:46:36 CET 2008
On Sat, Oct 25, 2008 at 01:05:59PM +0200, Uwe Hermann wrote:
> On Fri, Oct 24, 2008 at 03:31:20AM +0200, Peter Stuge wrote:
> > Uwe Hermann wrote:
> > > Drop the 'BIOS_' prefix from all printk() log-levels.
> > It would be nice to have another prefix though. Maybe LOG_ ? Without
> > a prefix some of the names look a bit too generic.
> I've though about that, but I don't see it as a big problem. Only
> "DEBUG" tends to be misused in v2, but we can easily avoid that by
> using DEBUG_SMBUS, DEBUG_FOOBAR #defines in v3 (if at all; all of
> those custom DEBUG #defines should be printk()-loglevels anyway;
> I think the reason for DEBUG in v2 is usually romcc/size relåted(?))
> If we all desperately want a prefix, how about something really short,
> e.g. LDEBUG, LWARN, LINFO, ... ? I'd really like to keep the printk()
> lines as short as possible for readability reasons.
Other opinions on this patch? Acks? ;) What does everyone think
of LDEBUG, LINFO etc.?
http://www.hermann-uwe.de | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
More information about the coreboot