[coreboot] More device cleanup

Myles Watson mylesgw at gmail.com
Wed Nov 5 22:48:20 CET 2008

On Wed, Nov 5, 2008 at 3:42 PM, ron minnich <rminnich at gmail.com> wrote:

> >
> > /** Set the method to be used for PCI, type I or type II
> >  */
> > void pci_set_method(struct device * dev)
> > {
> >     printk(BIOS_INFO, "Finding PCI configuration type.\n");
> >     dev->ops->ops_pci_bus = pci_check_direct();
> >     post_code(POST_STAGE2_PHASE2_PCI_SET_METHOD);
> > }
> >
> yeah, just set it. This is historical from when we supported type i or
> type ii, but nobody uses type ii

I left the infrastructure there so that it could be easily used for
memory-mapped checking.  Otherwise the whole file needs to die.

I also changed the function call, since it was only using the device pointer
to set the operations.  Now it uses the device pointer to tell it which ops
to check.

Signed-off-by: Myles Watson <mylesgw at gmail.com>

With this change, my other patch is build tested for qemu, norwich, &

Run-tested on qemu & serengeti.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20081105/b5589425/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: we_dont_do_type_2.diff
Type: text/x-patch
Size: 2262 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20081105/b5589425/attachment.diff>

More information about the coreboot mailing list