[coreboot] [PATCH] new board: LiPPERT Cool SpaceRunner-LX

Jens Rottmann JRottmann at LiPPERTEmbedded.de
Mon Nov 3 14:30:26 CET 2008


Hi Uwe,

> The only non-trivial change I made, was to add
>  * Copyright (C) 2007 Advanced Micro Devices, Inc.
> to the cache_as_ram_auto.c file, as that's (IMHO) the only non-trivial
> file copied from the db800 and thus needs to preserve the (C) of AMD.
> 
> But please correct me if that should be wrong, we can still fix that
> then in svn (CC'd also Marc and Jordan from AMD for input).

No, you're absolutely right, the AMD (C) line really should be included
there, because I kept parts of AMD's actual code. Thanks for pointing
this out.

However, I happened to notice that you also deleted all "Based on ..."
lines and I'm a little bit unhappy about this. As I said in my last
mail, I'd have liked to pay credit to the code that served me as
example. ... Well, at least the SpaceRunner-LX patch is in now. ...


But I have something else I'd like to ask you for. I am now resending 3
small fixes I tripped over during my work. I had already sent them last
week ("[PATCH]es remaining 3 of 7 assorted fixes"), but they seemed to
have been ignored. If you have time for it, would you please have a look
at least at the one patch that adds the GPIO I/O resources to the IT8712F?

Thanks a lot,
Jens





More information about the coreboot mailing list