[coreboot] buildrom compiler settings patch

Myles Watson mylesgw at gmail.com
Thu May 29 16:41:07 CEST 2008


On Thu, May 29, 2008 at 8:13 AM, Jordan Crouse <jordan.crouse at amd.com> wrote:
> On 28/05/08 11:00 -0600, Myles Watson wrote:
>> This is a simple patch which consolidates the compiler settings.  I think it
>> might be better somewhere else, but at least it is consolidated.
>>
>> Signed-off-by: Myles Watson <mylesgw at gmail.com>
>
> Acked-by: Jordan Crouse <jordan.crouse at amd.com>
>
>> I'm also interested in why we don't set LD at the same time.  Is it an
>> oversight?
>
> Probably - we might not have needed LD until this point.
>
>> I'd like to remove the compiler settings in Build.settings and error
>> out if there isn't a CC defined by then.  Maybe CONFIG_CC, CONFIG_LD,
>> CONFIG_AS, etc. settings in the Build Settings menu of Kconfig makes
>> sense.
>
> I like that!

Rev 199.

Thanks,
Myles




More information about the coreboot mailing list