[coreboot] [PATCH] artecgroup/dbe61: Set up some video memory, as the device has VGA output.

Mart Raudsepp mart.raudsepp at artecdesign.ee
Wed May 28 03:09:05 CEST 2008


> On 28.05.2008 02:27, Mart Raudsepp wrote:
>> artecgroup/dbe61: Set up some video memory, as the device has VGA
>> output.
>>
>> This allows me to have a working coreinfo payload on DBE61 with
>> coreboot-v3.
>>
>> Signed-off-by: Mart Raudsepp <mart.raudsepp at artecdesign.ee>
>> ---
>> Outside suggested commit message note:
>>
>> I think geode_video_mb should be a Kconfig option for boards that have
>> video output possible at all. The 16MB is picked because 8MB is not
>> enough
>> for WinCE, but this much is often not necessary to be allocated for
>> other
>> uses, so configurability would be nice.
>>
>
> Why not include that in the commit message? That way, we'll know in 2
> years from now why this was set to 16 MB.

I'd hope it's Kconfig configurable by then.

Anyhow, added a line saying

/* 16MB for now, as 8MB would not be enough for WinCE */

and stole the Acks for rev686


Thanks,
Mart Raudsepp





More information about the coreboot mailing list