[coreboot] fintek patch for f71805f

Richard Stellingwerff remenic at gmail.com
Tue May 20 15:13:16 CEST 2008


On Sat, May 17, 2008 at 11:48 PM, Uwe Hermann <uwe at hermann-uwe.de> wrote:
> Hi Corey,
>
> On Sat, May 17, 2008 at 03:41:00PM -0400, Corey Osgood wrote:
>> This looks like my hack job, it works well enough that the serial ports work
>> under linux, nothing else was ever tested. Might work might not. I need to
>> be added to the copyright holders, but Notepad seriously screws up the
>> formatting. With that change:
>>
>> Signed-off-by: Corey Osgood <corey.osgood at gmail.com>
>
> Please check the attched cleaned-up version with various fixes.
>
> I put yourself as sole copyright owner on both files, the one is
> trivial, the other probably too and/or mostly written by you so
> no problem I hope.
>
> Compile-tested with the latest EPIA-CN patch (switching the Super I/O),
> just to make sure it's compilable.
>
> Some of the changes:
>
>  - Drop useless debug code and uneeded #includes.
>  - Reorder functions to match the style of other Super I/Os in svn.
>  - Drop unneeded function prototypes.
>  - Use ARRAY_SIZE.
>  - Fill the whole pnp_dev_info struct, _BUT_ I'm not sure all the
>   0x7f8 etc. values are correct. I was not able to find the required
>   info in the F71805F datasheet, maybe somebody can enlighten me?
>   http://www.fintek.com.tw/files/productfiles/F71805F_V025.pdf
>  - Add TODO comments where needed.
>  - Random whitespace fixes and cosmetics.
>
>
> Uwe.

I tested this on my Jetway J7F4K1G2E-PB.

I can confirm that serial port works. Didn't try the other stuff.

Acked-by: Richard Stellingwerff <remenic at gmail.com>




More information about the coreboot mailing list