[coreboot] [PATCH] flashrom for ICH7 VT8237S

Rudolf Marek r.marek at assembler.cz
Tue May 20 00:31:27 CEST 2008

Hi all,

Here is preliminary patch for VT8237S SPI interface.  Thanks to Dominik and 
Claus great work only two hours of time were needed to port the code.
I was very surprised because it worked on first try (except the 3 byte RDID 
check below) Some routines are even same but copied, maybe it could be merged. 
Diff for yourself.

The ICH7 should work too once correct MMIO base is selected (this part is 
missing). VIA and ICH7 are very very similar here, I commented the differences 
in the source.

What works? Now it works with VT8237S + SPI flash MX25L4005 (512 KB) (read 
tested, rdid tested) and with Amic A25L40P 512KB - tested write,erase?, verify
(I just ran -wv) The AMIC flash continuation code is 1 byte so manuf ID is 2 
BYTES. And flash ID is two bytes too. So I had to extend the RDID command to 4 
bytes. Three byte flash like MX will repeat the first byte as seen on the 
attached dump.

Obviously the ... found at physical address 0xfff80000 is wrong too. Should not 
be printed when SPI controller.

In case someone wants to check the AMIC datasheet 
http://www.amictechnology.com/pdf/A25L40P.pdf I bought this flash for like 1.30 
EUR in http://gme.cz

I will have no time for this for nearly two weeks, so if someone wants to work 
on this here is the chance ;)

Well I can just Signed-of-by: Rudolf Marek <r.marek at assembler.cz> but the code 
needs cleanups etc - no time now.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: viaspi.patch
Type: text/x-diff
Size: 19862 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080520/927cc293/attachment.bin>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: dump_amic4B.txt
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080520/927cc293/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: dump_mx4B.txt
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080520/927cc293/attachment-0001.txt>

More information about the coreboot mailing list