[coreboot] fintek patch for f71805f

Uwe Hermann uwe at hermann-uwe.de
Sat May 17 23:48:09 CEST 2008


Hi Corey,

On Sat, May 17, 2008 at 03:41:00PM -0400, Corey Osgood wrote:
> This looks like my hack job, it works well enough that the serial ports work
> under linux, nothing else was ever tested. Might work might not. I need to
> be added to the copyright holders, but Notepad seriously screws up the
> formatting. With that change:
> 
> Signed-off-by: Corey Osgood <corey.osgood at gmail.com>

Please check the attched cleaned-up version with various fixes.

I put yourself as sole copyright owner on both files, the one is
trivial, the other probably too and/or mostly written by you so
no problem I hope.

Compile-tested with the latest EPIA-CN patch (switching the Super I/O),
just to make sure it's compilable.

Some of the changes:

 - Drop useless debug code and uneeded #includes.
 - Reorder functions to match the style of other Super I/Os in svn.
 - Drop unneeded function prototypes.
 - Use ARRAY_SIZE.
 - Fill the whole pnp_dev_info struct, _BUT_ I'm not sure all the
   0x7f8 etc. values are correct. I was not able to find the required
   info in the F71805F datasheet, maybe somebody can enlighten me?
   http://www.fintek.com.tw/files/productfiles/F71805F_V025.pdf
 - Add TODO comments where needed.
 - Random whitespace fixes and cosmetics.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: f71805f.patch
Type: text/x-diff
Size: 4846 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080517/4589cd57/attachment.bin>


More information about the coreboot mailing list