[coreboot] [PATCH] flashrom: SST25VF status register printing

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Fri May 16 00:35:11 CEST 2008


On 16.05.2008 00:01, Peter Stuge wrote:
> On Thu, May 15, 2008 at 04:37:40PM +0200, Carl-Daniel Hailfinger wrote:
>   
>> Print detailed status register information for SST25VF series flash.
>>
>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>>
>> Index: flashrom-ron/spi.c
>> ===================================================================
>> --- flashrom-ron/spi.c	(Revision 3321)
>> +++ flashrom-ron/spi.c	(Arbeitskopie)
>> @@ -214,7 +214,8 @@
>>  	switch (flash->manufacture_id) {
>>  	case ST_ID:
>>  	case MX_ID:
>> -		if ((flash->model_id & 0xff00) == 0x2000)
>> +		if (((flash->model_id & 0xff00) == 0x2000) ||
>> +		    ((flash->model_id & 0xff00) == 0x2500))
>>  			spi_prettyprint_status_register_st_m25p(status);
>>  		break;
>>  	case SST_ID:
>>     
>
> Note this also prints for all MX 20 and 25 flash. If that was
> intended;
>   

Well, MX25 SPI flash have model_id 0x20.. and there's no MX SPI chip
with model_id 0x25.., so this would have been correct. Code clarity
benefits from rearranging, so the patch was committed with the changes
discussed on IRC.

> Acked-by: Peter Stuge <peter at stuge.se>
>   

Thanks, r3323.


Regards,
Carl-Daniel




More information about the coreboot mailing list