[coreboot] [PATCH] flashrom: ST M25P40 bug?

Peter Stuge peter at stuge.se
Thu May 15 05:06:25 CEST 2008

On Thu, May 15, 2008 at 04:37:18AM +0200, Carl-Daniel Hailfinger wrote:
> > Needs a commit message of course.
> Add support for the JEDEC RES (Read Electronic Signature and Resume from
> Powerdown) SPI command to flashrom to identify older SPI chips which
> can't handle JEDEC RDID. Since RES gives a one-byte identifier which is
> shared among many different vendors and even different sizes, we want to
> match RES as a last resort if RDID returns 0xff 0xff 0xff.


> >> -	{"ST",		"M25P40",		ST_ID,		ST_M25P40,		512,	256,		TEST_UNTESTED,	probe_spi,		spi_chip_erase_c7,	spi_chip_write, spi_chip_read},
> >> +	{"ST",		"M25P40",		ST_ID,		ST_M25P40,		512,	256,		TEST_UNTESTED,	probe_spi_rdid,		spi_chip_erase_c7,	spi_chip_write, spi_chip_read},
> >> +	{"ST",		"M25P40(old)",		ST_ID,		ST_M25P40_RES,		512,	256,		TEST_UNTESTED,	probe_spi_res,		spi_chip_erase_c7,	spi_chip_write, spi_chip_read},
> >>     
> >
> > Hmm. probe_spi_res() calls spi_rdid() first. I don't like duplicating
> > chips? If multiple checks are needed for one chip I think they should
> > be in code?
> To be honest, the "M25P40(old)" entry should more look like
> "STM25P40/SST25something/AT26something/dozens_of_other_chips". For
> more details, see the changelog.

With name change per IRC discussion:

Acked-by: Peter Stuge <peter at stuge.se>

More information about the coreboot mailing list