[coreboot] [PATCH] flashrom: Infrastructure for ICH9 merge

[Carl-Daniel Hailfinger]

On 14.05.2008 16:50, Carl-Daniel Hailfinger wrote:
> On 14.05.2008 16:35, Stefan Reinauer wrote:
>   
>> Carl-Daniel Hailfinger wrote:
>>     
>>> Add more infrastructure for flashrom ICH9 support.
>>>
>>> Signed-off-by: Carl-Daniel Hailfinger
>>> <c-d.hailfinger.devel.2006 at gmx.net>
>>>       
>> Good direction, but I have to NACK for a few things:
>>
>> The rcrb has a size of 16K (0x4000). Please map the whole bar. Mapping
>> 14.5K of a 16K bar seems a bit artificial.
>>
>> The SPI bar is not a bar itself, but it is part of the RCBA. Please
>> just map this once and make ich_spibar point into that.
>>
>> Please don't open the memory device twice. Instead just change the
>> already existing open on the memory device to be uncached.
>>
>> With above changes:
>>
>> Acked-by: Stefan Reinauer <stepan at coresystems.de>
>>     
> Thanks for the review, fixed patch follows.
>
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>   

Committed in r3314.

Regards,
Carl-Daniel