[coreboot] Add support for SPI-Chips on ICH9 to flash rom / please delete the last mail

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Wed May 14 16:17:01 CEST 2008


Hi Claus,
hi Dominik,

On 14.05.2008 08:23, Claus Gindhart wrote:
> Hi Carl-Daniel,
>
> my colleague Dominik will investigate into this; we will provide a new patch 
> within the next few days.
>   

Thanks. By the way, the ICH8 datasheet says your code will not work with
ICH8 (wrong SPIBAR address), so you might want to remove ICH8 bits from
the patch. Hardcoding the RCRB address is a problem as well.

I have sent another patch a few minutes ago which will allow you to
replace is_supported_chipset() with ich9_detected and
curflash->virtual_registers with *ich_spibar. That patch also calculates
the correct RCRB address and the correct SPIBAR address. The subject of
the mail was "[coreboot] [PATCH] flashrom: Infrastructure for ICH9 merge".


Regards,
Carl-Daniel




More information about the coreboot mailing list