[coreboot] [PATCH] flashrom: ST M25P40 bug?
c-d.hailfinger.devel.2006 at gmx.net
Wed May 14 01:27:33 CEST 2008
On 12.05.2008 05:16, Peter Stuge wrote:
> On Sun, May 11, 2008 at 06:17:48PM +0200, Carl-Daniel Hailfinger wrote:
>> On 11.05.2008 18:01, Fredrik Tolf wrote:
>>> Yes, the flashrom code with that patch seems to detect my chip
>>> and read its contents quite well. However, the same code does not
>>> detect the original chip on the board??? (an MX25L4005)
>>> satisfactory, and it seems to be a conflict with the SPI code.
>> This is a side effect of r3291, the "multiple flash chip" patch.
> Yes, 3291 exposes this.
>> All of our SPI chips where a generic per-vendor fallback detection
>> exists (that's all of them right now) will exhibit this problem.
> I had reservations about "unknown SPI chip" and this is why.
> This is also why I don't like fake flash chip entries for forcing
> reads from undetectable chips.
> Both simply do not accurately describe or model what is actually
> going on and just end up confusing users and code.
Feel free to propose an alternative that works and doesn't uglify the
flashrom architecture. Be warned that this is difficult.
> It is ridiculous to claim that an "unknown chip" has been detected.
> If a chip had been positively detected it would not be unknown.
> This is behavior/language I could expect from commercial OS vendors.
That was a mismerge. The correct message would have been "unknown
Macronix SPI flash chip" and that's a big improvement over "no chip found".
> I think we have to stop saying this and instead flashrom needs
> infrastructure and commands that can correctly model and handle
> SPI situation where the memory bus master is no longer transparent.
Which infrastructure are you missing?
>> Fredrik, you should be able to work around this by calling
>> flashrom -c MX25L4005
>> The patch I sent does not have anything to do with the MX25L4005
>> problem you're seeing because that problem was introduced in r3291.
>> Can you signoff this patch since it works for you?
> Please do sign off the patch if it works for you Fredrik.
> There are issues in flashrom, but as Carl-Daniel writes they are
> not closely related and I think the proposed RES change can go in
> for now.
Indeed. I'm also looking for an Ack from someone who is not Fredrik or me.
The patch is bitrotting in my tree and all SPI restructuring conflicts
with it, so I have to merge manually every time.
More information about the coreboot