[coreboot] Outstanding patches
jordan.crouse at amd.com
Tue May 6 23:33:21 CEST 2008
On 06/05/08 14:59 -0600, Myles Watson wrote:
> On Tue, May 6, 2008 at 2:49 PM, Myles Watson <mylesgw at gmail.com> wrote:
> > > I have a number of outstanding patches that need to be ACKed or
> > > NAKed. Please review if you have the time:
> > >
> > > coreinfo submenu patch:
> > > http://www.coreboot.org/pipermail/coreboot/2008-April/033837.html
> > > coreinfo: Add "a submenu"
> > Here's a start for this one.
> I forgot to say that if you configure it without a couple of menus,
> it refuses to build because of unused variable warnings. I'm not sure
> that -Werror is the right thing to do when it's in buildrom, even
> though I don't like warnings.
Okay, this one was easy enough - the #include <arch/rdtsc.h> in
cpuinfo_module.c just had to be moved inside of the
#ifdef CONFIG_CPUINFO_MODULE define. It is trivial.
Systems Software Development Engineer
Advanced Micro Devices, Inc.
More information about the coreboot