[coreboot] patch: two bugs in the cs5536 ide code
Marc.Jones at amd.com
Tue May 6 18:27:16 CEST 2008
ron minnich wrote:
> I know some people will get upset by the find_pci_device, but:
> This patch fixes a long-standing problem in the cs5536 driver, that is
> probably also in v2.
> The ide_init is called with the sb device but needs the IDE device,
> which is different.
You are going to run into this problem on almost every chipset.
Integrated PCI devices is normal (IDE, SMB, SATA, USB, LPC, audio, etc).
> It also did a write_config8,not write_config32; this bug has been in there since
> the code was written for v2. I don't know how or why it ever worked,
> since PWB is 1<<14.
Yup, bug. I will post a v2 patch.
PWB should be set for better performance so it shouldn't cause complete
Senior Firmware Engineer
(970) 226-9684 Office
mailto:Marc.Jones at amd.com
More information about the coreboot