[coreboot] flashrom: Add tested bitmap to flashchips table.

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sat May 3 11:46:21 CEST 2008


On 03.05.2008 06:36, Peter Stuge wrote:
> Thanks for your comments!
>   

Thanks for taking them into account!

> On Sat, May 03, 2008 at 03:40:17AM +0200, Carl-Daniel Hailfinger wrote:
>   
>>> +	/* Indicate if flashrom has been tested with this flash chip and if
>>> +	 * everything worked correctly.
>>> +	 */
>>> +	uint8_t tested;
>>>   
>>>       
>> Due to alignment of the subsequent struct member, we'll waste 24 bits
>> here. We might as well make this a 32bit variable. It's not needed
>> right now, though.
>>     
>
> It felt a bit cramped with no free bits so I changed it to uint32_t.
>
>
>   
>>> +	if (TEST_OK_MASK != (flash->tested & TEST_OK_MASK)) {
>>> +		printf("--\n");
>>>   
>>>       
>> The printf above may be dangerous if it is interpreted as a
>> signature separator by some e-mail program...
>>     
>
> Changed to ===
>
>
>   
>> Maybe add: "In doubt, mail the whole output of flashrom."
>>     
>
> I changed the wording a bit.
>
>
>   
>> That also begs the question whether we want to echo the flashrom
>> parameters by default.
>>     
>
> Maybe, but I don't know if that would be useful?
>   

Just that if the user reports "It works" without further info, we know
immediately what works.


>> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>>     
>
> Thanks! r3277.
>   

Thanks!

Regards,
Carl-Daniel




More information about the coreboot mailing list