[coreboot] [PATCH] flashrom: ST M25P40 bug?
fredrik at dolda2000.com
Sat Mar 29 22:58:16 CET 2008
On Sat, 2008-03-29 at 22:17 +0100, Carl-Daniel Hailfinger wrote:
> > I'm attaching my patch to fix the problem. I would imagine that the
> > other M25Pxx chips would be affected by the same problem, but since I
> > can neither verify nor test what IDs they would have, they are excluded
> > from my patch.
> Thanks for investigating and coding this. However, I have to veto the
> patch in its current form. I know at least 4 flash chips with different
> sizes from different manufacturers which have the same RES code.
> Can you post the RDID output for your device? Maybe we can figure out a
> way to identify it safely with the help of RDID and RES and possibly READ.
The RDID output was just FF FF FF, so I'm pretty sure it just doesn't
recognize the command at all. How do you suppose the chip's identity
could be deduced from a READ command?
Would it perhaps not be wise to create a command-line switch to enable
detection for chips like this, that might not be possible to
auto-identify safely? The flashchip struct could be gifted with a
pre-initialized boolean that indicates if a chip should be
auto-identified without being explicitly specified.
More information about the coreboot