[coreboot] [patch] SST25VF016B (2MB) flash on m57sli (IT8716F).

[Ward Vandewege]

On Wed, Mar 12, 2008 at 09:56:55PM +0100, Ronald Hoogenboom wrote:
> On Tue, 2008-03-11 at 01:12 +0100, Carl-Daniel Hailfinger wrote:
> > On 10.03.2008 09:05, Ronald Hoogenboom wrote:
> > > This patch allows direct out-of-SPI-flash boot of a Linux kernel. It
> > > circumvents the 512KB limitation in the IT8716f superio of memory
> > > mapping an SPI flash device by using a PIO method for reading the data.
> > > Limitation: no nrv2b support.
> > >
> > > Signed-off-by: Ronald Hoogenboom <hoogenboom30 at zonnet.nl>
> > >   
> > 
> > src/stream/piorom_stream.c:
> > A missing license header.
> 
> I just imitated rom_stream.c, which hasn't got it either...
> 
> > 
> > src/mainboard/gigabyte/m57sli/Options.lb:
> > Changed to be SPI-only (rev 1.x boards will have problems).
> 
> Rev. 1.x boards would choose 512K rom, which changes the piorom_stream
> back to rom_stream (see the very first #if in piorom_stream). I agree
> this is ugly, but I couldn't make it work in the Options.lb with an 'if
> ROM_SIZE > 512*1024' - like construct.

... except for those of us who've soldered a socket onto a rev1 board of
course! I often use larger chips on a v1. 

So, this should really be spi-only. Carl-Daniel; was your e-mail a list of
actual changes you had made, or just a list of 'things to be changed'? There
was no patch attached but it kind of sounded like you had already fixed those
things.

Thanks,
Ward.

-- 
Ward Vandewege <ward at fsf.org>
Free Software Foundation - Senior System Administrator