[coreboot] [PATCH] Make RAM check configurable via Kconfig

Peter Stuge peter at stuge.se
Mon Mar 17 13:03:42 CET 2008


On Mon, Mar 17, 2008 at 03:09:19AM -0400, Corey Osgood wrote:
> IMO, ram_check should be a lot more advanced and configurable then
> it already is.

Disagree.

ram_check() is a VERY simplistic test that is only usable for
determining if RAM init is now good enough to _maybe_ allow the rest
of coreboot and eventually a payload to run. Once it returns success
there will be more code needed to be written before a full payload
can be started, so it does have a purpose.


> The reasoning is that many problems, both with coreboot/BIOS and
> OS, can be attributed to the memory.

And this is why booting memtest86 or similar advanced test tool
must be a mandatory (late) step in every new port.

We do not want to integrate that into coreboot startup, not even
hidden behind a configuration variable. We should not and must not.


Personally I would like to see all ram_check() calls removed from
current code for boards that are working, and a rule that we never
allow it to be committed for a new board that is considered to be
working.


//Peter




More information about the coreboot mailing list