[coreboot] [PATCH] Make RAM check configurable via Kconfig

[Stefan Reinauer]

Carl-Daniel Hailfinger wrote:
> On 16.03.2008 23:16, Stefan Reinauer wrote:
>   
>> ron minnich wrote:
>>   
>>     
>>> So, I am curious.
>>>
>>> I see this:
>>> 	ram_check(0, 640 * 1024);
>>>
>>> in a file. Could I be forgiven in thinking that a ram check might be
>>> done? I realize this is the "linux style" but I have never
>>> particularly liked it.
>>>
>>> What is wrong with
>>> #ifdef RAMTEST
>>> 	ram_check(0, 640 * 1024);
>>> #endif
>>>
>>> What do people prefer? Maybe I am just out of touch.  
>>>     
>>>       
>> This ram test is nothing that a user should ever see. it is left over
>> development code.
>>   
>>     
>
> Agreed, but at the same time, I'd like to keep this in the code as
> reference for future porters. Maybe have it depend on
> CONFIG_PARANOID_CHECKING or something like that?
> Or we simply comment it out once the board is running perfectly.
>   
Yes, I agree.

Stefan

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de  • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080317/26d22972/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080317/26d22972/attachment.sig>