[coreboot] [PATCH] Make RAM check configurable via Kconfig

ron minnich rminnich at gmail.com
Mon Mar 17 05:43:19 CET 2008

On Sun, Mar 16, 2008 at 6:44 PM, Carl-Daniel Hailfinger
<c-d.hailfinger.devel.2006 at gmx.net> wrote:

>  Agreed, but at the same time, I'd like to keep this in the code as
>  reference for future porters. Maybe have it depend on
>  CONFIG_PARANOID_CHECKING or something like that?
>  Or we simply comment it out once the board is running perfectly.

We're spending a lot of time on this one :-)

i can't debug without the memtest, but it is true that we don't need
it once a board works.

One conclusion I come away with, which you may all disagree with.

#ifdef option is the wrong way to go. Options should always have a
defined value. Why? So we can let C do its job, e.g.:
if (CONFIG_THIS_THAT == 'y') {

This code will be enabled or completely optimized out, and it's pretty
clear what's up. And it looks more like C than:

That's my main conclusion from this thread, but I'm not worried enough
about it either way to argue the point too much.



More information about the coreboot mailing list