[coreboot] [PATCH] flashrom: Add ICH9 detection

Uwe Hermann uwe at hermann-uwe.de
Sat Mar 15 01:10:22 CET 2008


On Fri, Mar 14, 2008 at 06:53:07PM +0100, Carl-Daniel Hailfinger wrote:
> Add ICH9 detection to flashrom. Straight from the datasheet, untested.
> 
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Looks good, compiles fine.

Acked-by: Uwe Hermann <uwe at hermann-uwe.de>


> Index: flashrom-ich9/chipset_enable.c
> ===================================================================
> --- flashrom-ich9/chipset_enable.c	(Revision 3144)
> +++ flashrom-ich9/chipset_enable.c	(Arbeitskopie)
> @@ -208,7 +208,8 @@
>  	bbs = (gcs >> 10) & 0x3;
>  	printf_debug("BOOT BIOS Straps: 0x%x (%s)\n",	bbs,
>  		     (bbs == 0x3) ? "LPC" : ((bbs == 0x2) ? "PCI" : "SPI"));
> -	printf_debug("SPIBAR = 0x%x\n", tmp + 0x3020);
> +	/* SPIBAR is at RCBA+0x3020 for ICH[78] and RCBA+0x3800 for ICH9. */
> +	/* printf_debug("SPIBAR = 0x%x\n", tmp + 0x3020); */
>  	/* TODO: Dump the SPI config regs */
>  	munmap(rcba, 0x3510);
>  
> @@ -584,6 +585,12 @@
>  	{0x8086, 0x2812, "Intel ICH8DH",	enable_flash_ich_dc_spi},
>  	{0x8086, 0x2814, "Intel ICH8DO",	enable_flash_ich_dc_spi},
>  	{0x8086, 0x2815, "Intel ICH8M",		enable_flash_ich_dc_spi},
> +	{0x8086, 0x2912, "Intel ICH9DH",	enable_flash_ich_dc_spi},
> +	{0x8086, 0x2914, "Intel ICH9DO",	enable_flash_ich_dc_spi},
> +	{0x8086, 0x2916, "Intel ICH9R",		enable_flash_ich_dc_spi},
> +	{0x8086, 0x2917, "Intel ICH9M-E",	enable_flash_ich_dc_spi},
> +	{0x8086, 0x2918, "Intel ICH9",		enable_flash_ich_dc_spi},
> +	{0x8086, 0x2919, "Intel ICH9M",		enable_flash_ich_dc_spi},
>  	{0x1106, 0x8231, "VIA VT8231",		enable_flash_vt823x},
>  	{0x1106, 0x3177, "VIA VT8235",		enable_flash_vt823x},
>  	{0x1106, 0x3227, "VIA VT8237",		enable_flash_vt823x},


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org




More information about the coreboot mailing list