[coreboot] pc speaker and cs5536

Uwe Hermann uwe at hermann-uwe.de
Fri Mar 14 18:13:51 CET 2008

On Fri, Mar 14, 2008 at 12:06:34PM +0500, Nikolay Petukhov wrote:
> 2008/3/13, Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>:
> > Maybe call it from mainboard.c, but keep the function inside the cs5536
> >  code.
> >
> Maybe then so.

Looks good, but please repost with a Signed-off-by, otherwise we cannot
commit, see my other mail.

Also, you seem to create your patches manually with diff, which is fine,
but doing 'svn diff > foo.patch' in the tree is usually faster and

http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

More information about the coreboot mailing list